Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Update sriov v1.3.0 #6725

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Sep 4, 2024

Backport: #6706
Issue: #6721

Also updates node-feature-discovery to `0.15.6`

Signed-off-by: Michael Fritch <[email protected]>
(cherry picked from commit 74fc499)
@mgfritch mgfritch requested a review from a team as a code owner September 4, 2024 17:34
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs chart bump?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.57%. Comparing base (254a9f5) to head (8b0a347).

❗ There is a different number of reports uploaded between BASE (254a9f5) and HEAD (8b0a347). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (254a9f5) HEAD (8b0a347)
unittests 1 0
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #6725       +/-   ##
================================================
- Coverage         25.18%   9.57%   -15.62%     
================================================
  Files                33      33               
  Lines              2831    2831               
================================================
- Hits                713     271      -442     
- Misses             2071    2537      +466     
+ Partials             47      23       -24     
Flag Coverage Δ
inttests 9.57% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgfritch
Copy link
Contributor Author

mgfritch commented Sep 5, 2024

needs chart bump?

#6706 (comment)

@thomasferrandiz
Copy link
Contributor

replaced by #6757

@mgfritch mgfritch deleted the update-sriov-v1.3.0-release-1.28 branch September 7, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants